-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Zk Grep #171
Draft
shfattig
wants to merge
8
commits into
zk-org:main
Choose a base branch
from
shfattig:zk_grep
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Zk Grep #171
Commits on Jun 22, 2024
-
Configuration menu - View commit details
-
Copy full SHA for aa45809 - Browse repository at this point
Copy the full SHA aa45809View commit details -
Add conditional on 'grep' argument in pick_notes()
if the 'grep' argument is provided, the ui is called directly. the api is not called with the ui as a callback (as would normally be the case) because in this case the ui has to call the api on each input change
Configuration menu - View commit details
-
Copy full SHA for 6e786f4 - Browse repository at this point
Copy the full SHA 6e786f4View commit details -
Condition pick_notes() on 'grep' option
run grep picker if 'grep' is given, otherwise run the other one
Configuration menu - View commit details
-
Copy full SHA for 4034cd5 - Browse repository at this point
Copy the full SHA 4034cd5View commit details -
picker uses asynchronous calls to "zk list -m <search_term>" to live filter notes based on a search term implemented based on Telescope's live_grep does not include ability to jump to line since "zk list" does not give this info
Configuration menu - View commit details
-
Copy full SHA for 4c66abd - Browse repository at this point
Copy the full SHA 4c66abdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4499af1 - Browse repository at this point
Copy the full SHA 4499af1View commit details
Commits on Sep 25, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 81bb6b8 - Browse repository at this point
Copy the full SHA 81bb6b8View commit details
Commits on Sep 28, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 20a3058 - Browse repository at this point
Copy the full SHA 20a3058View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8357420 - Browse repository at this point
Copy the full SHA 8357420View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.