[Fix-426][Metric] fix DiffPercentage calculation rules (datavane#427)

zixi0825 · Aug 22, 2024 · 5ef349e · 5ef349e
1 parent 066ebe4
commit 5ef349e
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/...mula-diff-percentage/src/main/java/io/datavines/metric/result/formula/DiffPercentage.java b/...mula-diff-percentage/src/main/java/io/datavines/metric/result/formula/DiffPercentage.java
@@ -38,8 +38,8 @@ public String getZhName() {
     @Override
     public BigDecimal getResult(BigDecimal actualValue, BigDecimal expectedValue) {
         BigDecimal result = BigDecimal.valueOf(0);
-        if (expectedValue != null && expectedValue.compareTo(BigDecimal.ZERO) != 0) {
-            BigDecimal quotient = actualValue.divide(expectedValue, 2, RoundingMode.HALF_UP);
+        if (expectedValue != null && expectedValue.compareTo(BigDecimal.ZERO) != 0 && actualValue != null) {
+            BigDecimal quotient = actualValue.subtract(expectedValue).abs();
             result = quotient.divide(expectedValue, 2, RoundingMode.HALF_UP).multiply(new BigDecimal(100));
         }