Allow empty discoveryId #110
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Moin, sorry für meine späte Reaktion - ich war ein paar Wochen offline. Grundsätzlich spricht nichts dagegen, aber ich würde gern sichergehen, dass ich das Problem verstehe (deshalb jetzt auch auf deutsch) und die Auswirkung auf alle anderen User so gering wie möglich halten. In #103 sieht es so aus, als würden die zusätzlichen Parameter dein Problem lösen - oder hab ich den zu früh geschlossen? Wie genau sieht dein MQTT Tree aktuell aus, und wie soll er aussehen? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was wondering for quite some time, why nothing really worked anymore.
Looks like the fix for #101 (i.e. ignoring empty discoveryID) killed it for me.
Would it be possible to implement something like what I dabbled together in this PR?