Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: acceptance test suite #256

Merged
merged 40 commits into from
Nov 19, 2024
Merged

chore: acceptance test suite #256

merged 40 commits into from
Nov 19, 2024

Conversation

stebenz
Copy link
Contributor

@stebenz stebenz commented Oct 31, 2024

Definition of Ready

  • I am happy with the code
  • Short description of the feature/issue is added in the pr description
  • PR is linked to the corresponding user story
  • Acceptance criteria are met
  • All open todos and follow ups are defined in a new ticket and justified
  • Deviations from the acceptance criteria and design are agreed with the PO and documented.
  • Vitest unit tests ensure that components produce expected outputs on different inputs.
  • Cypress integration tests ensure that login app pages work as expected. The ZITADEL API is mocked.
  • No debug or dead code
  • My code has no repetitions

Copy link

vercel bot commented Oct 31, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
typescript-login ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 19, 2024 3:21pm

…ptance-test-suite

# Conflicts:
#	acceptance/tests/idp-apple.spec.ts
#	acceptance/tests/idp-generic-jwt.spec.ts
#	acceptance/tests/idp-generic-oauth.spec.ts
#	acceptance/tests/idp-generic-oidc.spec.ts
#	acceptance/tests/idp-github-enterprise.spec.ts
#	acceptance/tests/idp-github.spec.ts
#	acceptance/tests/idp-gitlab-self-hosted.spec.ts
#	acceptance/tests/idp-gitlab.spec.ts
#	acceptance/tests/idp-google.spec.ts
#	acceptance/tests/idp-ldap.spec.ts
#	acceptance/tests/idp-microsoft.spec.ts
#	acceptance/tests/idp-saml.spec.ts
#	acceptance/tests/login-configuration-possiblities.spec.ts
@peintnermax peintnermax marked this pull request as ready for review November 19, 2024 15:57
@peintnermax peintnermax merged commit 699abeb into main Nov 19, 2024
7 checks passed
@peintnermax peintnermax deleted the acceptance-test-suite branch November 19, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants