Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(acceptance): username password #227

Merged
merged 43 commits into from
Oct 28, 2024
Merged

test(acceptance): username password #227

merged 43 commits into from
Oct 28, 2024

Conversation

eliobischof
Copy link
Member

@eliobischof eliobischof commented Oct 16, 2024 •
edited
Loading

Runs an acceptance test against a local ZITADEL API in the pipeline.

Definition of Ready

  • I am happy with the code
  • Short description of the feature/issue is added in the pr description
  • PR is linked to the corresponding user story
  • Acceptance criteria are met
  • All open todos and follow ups are defined in a new ticket and justified
  • Deviations from the acceptance criteria and design are agreed with the PO and documented.
  • Vitest unit tests ensure that components produce expected outputs on different inputs.
  • Cypress integration tests ensure that login app pages work as expected. The ZITADEL API is mocked.
  • No debug or dead code
  • My code has no repetitions

@vercel Vercel
Copy link

vercel bot commented Oct 16, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
typescript-login ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 18, 2024 11:31pm

@eliobischof eliobischof linked an issue Oct 18, 2024 that may be closed by this pull request
ZITADEL New Login UI: Standardize the way of writing and running acceptance tests. #7
Open
3 tasks
@eliobischof eliobischof marked this pull request as ready for review October 18, 2024 23:30
@eliobischof eliobischof self-assigned this Oct 18, 2024
@peintnermax peintnermax merged commit 0e07da3 into qa Oct 28, 2024
7 checks passed
@peintnermax peintnermax deleted the acceptance-test-suite branch October 28, 2024 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peintnermax peintnermax peintnermax approved these changes

Assignees

@eliobischof eliobischof

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ZITADEL New Login UI: Standardize the way of writing and running acceptance tests.
2 participants
@eliobischof @peintnermax