Prefer attributes, deprecate annotations #1651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fulldecent
changed the title
|
This adds a deprecation notice so we can soon update to only supported PHP versions. For reference, here are the supported versions of PHP. Please note that future versions of PHP will have longer support cycles (just for the security support, not the active support), however 7.4 and even 8.0 are specifically excluded. This is a clear signal to the community not to use 7.4 and 8.0. |
DerManoMann
requested changes
Sep 22, 2024
DerManoMann
requested changes
Sep 22, 2024
README.md
Outdated
| @@ -19,6 +20,8 @@ For a full list of supported annotations, please have look at the [`OpenApi\Anno | |||
| - Exceptional error reporting (with hints, context) | |||
| - As of PHP 8.1 all annotations are also available as PHP attributes | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
oh, another nit: why these extra lines?
There was a problem hiding this comment.
ugggh prettier, that's why :-(
There was a problem hiding this comment.
did rebase squash should be fixed now
|
Squash rebase, fix whitespace |
DerManoMann
approved these changes
Sep 25, 2024
|
Thanks @fulldecent |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.