Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-implement TokenScanner using nikic/php-parser #1597

Merged
merged 6 commits into from
Jun 3, 2024
Merged

Re-implement TokenScanner using nikic/php-parser #1597

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c6ffb7c
Add php-parser dep and refactor `TokenScanner` to use it
DerManoMann Jun 3, 2024
6f2ca2c
Update phpstan baseline
DerManoMann Jun 3, 2024
0902210
Tweak implementation / tests
DerManoMann Jun 3, 2024
4432b4a
Fix scratch test namespaces
DerManoMann Jun 3, 2024
3230adc
Handle no namespace
DerManoMann Jun 3, 2024
7c81088
Fix last scratch now that we have a no namespace fixture
DerManoMann Jun 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@
"require": {
"php": ">=7.2",
"ext-json": "*",
"nikic/php-parser": "^4.19",
"psr/log": "^1.1 || ^2.0 || ^3.0",
"symfony/deprecation-contracts": "^2 || ^3",
"symfony/finder": ">=2.2",
Expand Down
2 changes: 1 addition & 1 deletion phpstan-baseline.neon
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ parameters:
path: Examples/using-links-php81/User.php

-
message: "#^Strict comparison using \\=\\=\\= between array\\|string and false will always evaluate to false\\.$#"
message: "#^Call to function array_key_exists\\(\\) with string and array\\{\\} will always evaluate to false\\.$#"
count: 1
path: src/Analysers/TokenScanner.php

Expand Down
Loading