Enum can have boolean values #1467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You will need to update the annotation classes too to make the tests pass... |
|
thanks done |
DerManoMann
requested changes
Sep 1, 2023
src/Annotations/ServerVariable.php
Outdated
| @@ -27,7 +27,7 @@ class ServerVariable extends AbstractAnnotation | |||
| /** | |||
| * An enumeration of values to be used if the substitution options are from a limited set. | |||
| * | |||
| * @var string[]|int[]|float[]|\UnitEnum[]|class-string | |||
| * @var string[]|int[]|float[]|\UnitEnum[]|class-string|bool[] | |||
There was a problem hiding this comment.
Ah, just a minor thing, but one I'd like to see changed for consistency - could you move the bool[] adjunct to string,int,float, please, so the native types are all together?
Suggested change
| * @var string[]|int[]|float[]|\UnitEnum[]|class-string|bool[] | |
| * @var string[]|int[]|float[]|bool[]|\UnitEnum[]|class-string |
DerManoMann
approved these changes
Sep 12, 2023
|
Thanks @momala454 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.