Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix off-by-one bug in msgpack decoding #742

Merged
merged 2 commits into from
Sep 17, 2024
Merged

Fix off-by-one bug in msgpack decoding #742

merged 2 commits into from
Sep 17, 2024

Conversation

tomwadeson
Copy link
Contributor

@tomwadeson tomwadeson commented Sep 16, 2024 •
edited by 987Nabil
Loading

A bug is present in MessagePackDecoder, affecting all caseClassNDecoders from 9..22. This results in the following error when decoding:

MalformedFieldWithPath(
        path = Chunk(),
        message = "Different than expected number of fields. Expected 8 but received 9"
      )

fixes #743

@tomwadeson tomwadeson requested a review from a team as a code owner September 16, 2024 10:15
@tomwadeson tomwadeson mentioned this pull request Sep 16, 2024
Closed
@googley42
Copy link
Contributor

googley42 commented Sep 17, 2024 •
edited
Loading

hey @tomwadeson you may gain some more traction from the maintainers if you mention the issue in the discord channel

@987Nabil 987Nabil merged commit a5cec32 into zio:main Sep 17, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@987Nabil 987Nabil 987Nabil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Off-by-one bug in msgpack decoding
3 participants
@tomwadeson @googley42 @987Nabil