Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scala 3 Macro generates invalid typeName #694

Closed
987Nabil opened this issue Jun 18, 2024 · 4 comments · Fixed by #702
Closed

Scala 3 Macro generates invalid typeName #694

987Nabil opened this issue Jun 18, 2024 · 4 comments · Fixed by #702
Labels
💎 Bounty bug Something isn't working 💰 Rewarded

Comments

@987Nabil
Copy link
Contributor

The Scala 3 macro has a bug. It adds the list of type params to the typeName of the TypeId.Nominal
Screenshot 2024-06-18 at 19 51 06

See zio/zio-http#2767
@987Nabil 987Nabil added the bug Something isn't working label Jun 18, 2024
@jdegoes
Copy link
Member

jdegoes commented Jun 28, 2024

/bounty $100

@algora-pbc Algora PBC
Copy link

algora-pbc bot commented Jun 28, 2024 •
edited
Loading

💎 $100 bounty • ZIO

Steps to solve:

  1. Start working: Comment /attempt #694 with your implementation plan
  2. Submit work: Create a pull request including /claim #694 in the PR body to claim the bounty
  3. Receive payment: 100% of the bounty is received 2-5 days post-reward. Make sure you are eligible for payouts

Thank you for contributing to zio/zio-schema!

Add a bounty • Share on socials

Attempt Started (GMT+0) Solution
🟢 @987Nabil #702

987Nabil added a commit to 987Nabil/zio-schema that referenced this issue Jun 28, 2024
@987Nabil
Generate in Scala 3 macro typeId without type parameters (zio#694)
96b86a8
@987Nabil 987Nabil mentioned this issue Jun 28, 2024
Merged
@algora-pbc Algora PBC
Copy link

algora-pbc bot commented Jun 28, 2024

💡 @987Nabil submitted a pull request that claims the bounty. You can visit your bounty board to reward.

987Nabil added a commit to 987Nabil/zio-schema that referenced this issue Jun 28, 2024
@987Nabil
Generate in Scala 3 macro typeId without type parameters (zio#694)
dda7f45
987Nabil added a commit to 987Nabil/zio-schema that referenced this issue Jun 28, 2024
@987Nabil
Generate in Scala 3 macro typeId without type parameters (zio#694)
29ebfda
987Nabil added a commit to 987Nabil/zio-schema that referenced this issue Jun 29, 2024
@987Nabil
Generate in Scala 3 macro typeId without type parameters (zio#694)
b6699e7
987Nabil added a commit to 987Nabil/zio-schema that referenced this issue Jun 29, 2024
@987Nabil
Generate in Scala 3 macro typeId without type parameters (zio#694)
6676045
987Nabil added a commit to 987Nabil/zio-schema that referenced this issue Jul 9, 2024
@987Nabil
Generate in Scala 3 macro typeId without type parameters (zio#694)
53c87bb
jdegoes pushed a commit that referenced this issue Jul 14, 2024
@987Nabil
Generate in Scala 3 macro typeId without type parameters (#694) (#702)
5c8e7eb
@algora-pbc Algora PBC
Copy link

algora-pbc bot commented Jul 14, 2024

🎉🎈 @987Nabil has been awarded $100! 🎈🎊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
💎 Bounty bug Something isn't working 💰 Rewarded
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Generate in Scala 3 macro typeId without type parameters (#694) 987Nabil/zio-schema
2 participants
@jdegoes @987Nabil