Generate in Scala 3 macro typeId without type parameters (#694) #702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
987Nabil
force-pushed
the
fix-scala3-macro-generic-name
branch
4 times, most recently
from
b6699e7 to
6676045
Compare
987Nabil
commented
Jun 29, 2024
| @@ -6,7 +6,7 @@ trait SchemaPlatformSpecific { | |||
| Schema[String].transformOrFail( | |||
| string => | |||
| try { | |||
| Right(new java.net.URL(string)) | |||
| Right(new java.net.URI(string).toURL) | |||
There was a problem hiding this comment.
I sneaked that one in. The URL constructor is deprecated in Java 21+ and this is the recommended migration
987Nabil
force-pushed
the
fix-scala3-macro-generic-name
branch
from
6676045 to
53c87bb
Compare
jdegoes
approved these changes
Jul 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #694
/claim #694