-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DRAFT] Implement Ledger Support #1513
base: dev
Are you sure you want to change the base?
Conversation
67d09d3
to
2a20318
Compare
@Oscar-Pepper here's the point where the single WalletCapability falls short. I think I can apply a refactor where we extract the inner workings of WalletCapability into an internal trait that implements a visitor pattern that calls the corresponding variant without exposing that there is a variant WalletCapability |
How is this related to #1352 ? Does this supersede that PR? Should that PR still be open? |
That one unfortunately has been made obsolete by the new UnifiedKeystore work. I'm using it as reference only. |
310761a
to
3d2caf5
Compare
@zancas @Oscar-Pepper I rebased and updated this PR |
3d2caf5
to
329f37e
Compare
439cd57
to
b173147
Compare
@Oscar-Pepper and I debated a bit on how to integrate ledger under the new UnifiedKeyStore architecture.
This PR will be implementing those changes gradually. There are a lot of build problems that are blocking the full integration and need to be solved but all the structural code here will work around that
Kickstarting ideas from Pepper