Skip to content

Commit

Permalink
THRIFT-4653: ES6 classes support (apache#1615)
Browse files Browse the repository at this point in the history
* ES6 classes support
* Lint generated code
* ES6 Tests for NodeJS
* Add eslint rules for nodejs
* Run prettier/eslint on nodejs test code
  • Loading branch information
bforbis authored and jeking3 committed Oct 28, 2018
1 parent cd829a0 commit da1169d
Show file tree
Hide file tree
Showing 18 changed files with 5,131 additions and 2,051 deletions.
9 changes: 9 additions & 0 deletions .eslintignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
# TODO: Use eslint on js lib and generated code

# Ignore lib/js for now, which uses jshint currently
lib/js/*
# Ignore all generated code for now
**/gen-*

# Don't lint nested node_modules
**/node_modules
24 changes: 24 additions & 0 deletions .eslintrc.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
{
"env": {
"es6": true,
"node": true
},
"extends": [
"eslint:recommended",
"plugin:prettier/recommended"
],
"parserOptions": {
"ecmaVersion": 2017
},
"rules": {
"no-console": "off",
"no-var": "error",
"prefer-const": "error",
"no-constant-condition": [
"error",
{
"checkLoops": false
}
]
}
}
Loading

0 comments on commit da1169d

Please sign in to comment.