🥗🧹 Tobias: Models have their Relationships and Attributes defined
#20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While it may be better us to void a `Payout`, making sure we clean up any `Payout#payments` upon `Payout#destroy` should reduce the likelihood of data being in a sad place.
This is not super important to the actual feature, but it does mean that the `Payment` has clearly defined relationships, with tests that confirm the relationship. It also adds a spec to check that the `#amount` value operates as a monetized value; which doesn't seem like it does that much beyond giving us an injection point for layering in additional details.
A few more `Payout` bits that didn't have specs! Now they do!
Again, we may want to leverage an archival system rather than destruction, but for now let's make sure we clean up when a `Trust` is detroyed.
zspencer
force-pushed
the
tobias/payout/destroying-a-payout-destroys-payments
branch
from
a235550 to
9ad211f
Compare
zspencer
changed the title
Tobias: Models have their Relationships and Attributes definedTobias: Models have their Relationships and Attributes defined
zspencer
deleted the
tobias/payout/destroying-a-payout-destroys-payments
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is perhaps a bit "extra" but I find appeasing the Rails gods by declaring Model attributes and relationships (plus their inverses and their dependent behavior) explicitly results in code that is easier to read and understand.
It could be argued a strong type system would eliminate all of this; which is why the Cool Kids have moved to Rust and Elixir.
I'm not a Cool Kid tho.