🧹 Tobias: Refactor Payout#issue and supporting code
#14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zspencer
force-pushed
the
tobias/payout/implement-first-pass-of-issue-method
branch
from
2afb0d2 to
9a1e213
Compare
zspencer
force-pushed
the
tobias/payout/refactor-pass-after-first-draft-of-issue
branch
from
9b5b260 to
8c40791
Compare
zspencer
force-pushed
the
tobias/payout/implement-first-pass-of-issue-method
branch
from
9a1e213 to
4ca8de0
Compare
Base automatically changed from
tobias/payout/implement-first-pass-of-issue-method
to
tobias/issuing-payouts
January 29, 2024 22:24
There was a number of things I didn't love about my implementation of `Payout#issue`: - I had added a `Tobias::Record` far earlier than necessary - There were linter errors - `Payout#payout_amount` felt redundant This remediates those nose-wrinkles, and sets us up nicely for the next test.
zspencer
force-pushed
the
tobias/payout/refactor-pass-after-first-draft-of-issue
branch
from
8c40791 to
b27654c
Compare
zspencer
deleted the
tobias/payout/refactor-pass-after-first-draft-of-issue
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tobias: Issuing aPayout #11There was a number of things I didn't love about my implementation of
Payout#issue:Tobias::Recordfar earlier than necessaryPayout#payout_amountfelt redundantThis remediates those nose-wrinkles, and sets us up nicely for the next test.