Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INTERNAL] Fix devcontainer workflow #2414

Closed
wants to merge 3 commits into from
+5 −2
Closed

[INTERNAL] Fix devcontainer workflow #2414

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cb982b8
Make devcontainer have correct version of Ruby installed.
anaulin May 23, 2024
e4d0068
Temporarily run this on every branch push.
anaulin May 23, 2024
3b72f96
Test
anaulin May 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .devcontainer/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM mcr.microsoft.com/devcontainers/ruby:3.3
FROM mcr.microsoft.com/devcontainers/ruby:3.3.0

LABEL org.opencontainers.image.source=https://github.com/zinc-collective/convene-devcontainer
LABEL org.opencontainers.image.description="Container to facilitate easier development of convene, specifically to work in GitHub CodeSpaces."
Expand Down
3 changes: 3 additions & 0 deletions .devcontainer/devcontainer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,9 @@
"workspaceFolder": "/workspaces/${localWorkspaceFolderBasename}",
"features": {
"ghcr.io/devcontainers/features/docker-in-docker:2": {},
"ghcr.io/devcontainers/features/ruby:1": {
"version": "3.3.0"
},
"node": {
"version": "16",
"nodeGypDependencies": true
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/build-publish-devcontainer.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
name: Create and publish Docker devcontainer
on:
push:
branches: ['main', 'neighborhood/speed-up-devcontainer-startup'] # second branch is temporary for testing...
#branches: ['main', 'neighborhood/speed-up-devcontainer-startup'] # second branch is temporary for testing...
paths:
- .github/workflows/build-publish-devcontainer.yml
- .devcontainer/Dockerfile
Expand Down
Loading