🧹 Journal: Excludes specs from primary GH workflow
#2174
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zspencer
changed the title
Journal: Excludes specs from primary GH workflow
|
Ah, this is great! I'll enable that Workflow in this repo! |
zspencer
force-pushed
the
exclude-redundant-journal-giz-specs
branch
from
e81e1e4 to
b1c7c77
Compare
|
I did a timecheck, and it looks like doing them in parallel adds about 2.5 compute minutes to the build while keeping the wall-time about the same. ETA: I think this means it's probably better to run them all as one big suite in the main repo; at least until we have enough parallelization optimizations to reduce the wall-time in exchange for added compute time |
|
I'm also worried about what happens if a change to Convene core accidentally breaks something on the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@zspencer in regards to https://github.com/zinc-collective/convene/pull/2161/files#r1477117473, eventually splitting and parallelizing test sounds cool -- if the project grows. In the meantime I thought this small change to the command in the main github action config would help signal in the code as to what's currently happening with splitting out journal.