🐞🔨 Section: Deleting Sections is possible again
#1900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- #1841 So, this was caused by me being FANCY and putting the delete button in the same form as the edit and update. A bad idea. Now, deleting a Section is handled in it's own independent form, rather than attempting to rewrite the forms hidden `_method` field to trick Rails into doing a destroy. This is also better from a design perspective because: A) omg, a delete button so close to the save button is DANGEROUS B) Deleting a Section is kinda a big deal, and while it would be better to bubble-wrap the heck out of it so people who *do* delete a section don't wind up in a sad-mad state; we can at least give them lots of "DANGER WILL ROBINSON DANGER" messaging. This is... irresponsible of us but what we can do now. If a motivated bystander or contributor wanted to design and implement a way for Sections to be Archived instead; I would be Very Happy ™️
anaulin
approved these changes
Oct 19, 2023
| @@ -20,3 +20,17 @@ | |||
| <%= render "furnitures/new", furniture: new_furniture %> | |||
| <%- end %> | |||
| <% end %> | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
I wish we had an erb linter that worked
| <h2>Remove this Section?</h2> | ||
| <%- data = {} %> | ||
| <%- if !room.gizmos.reload.empty? %> | ||
| <p>Warning! Deleting this Section will also delete all Gizmos and their related data. Please be very sure you want to do this! We recommend making the Section "internal" instead.</p> |
There was a problem hiding this comment.
Ideally these strings would be I18n-ed, but I don't think that's a blocker for merging this.
Good call on this warning and on having a confirm on the delete button.
| # Design note: It would be far better for us to have a way to safely undo | ||
| # the deletion of a Section, or even put the Gizmos into a holding space | ||
| # or something to be re-assigned; but that is out of scope for me at the | ||
| # moment - ZS 10/18/23 |
There was a problem hiding this comment.
Eventually: use the discard gem or similar?
rosschapman
pushed a commit
that referenced
this pull request
Oct 23, 2023
- #1841 So, this was caused by me being FANCY and putting the delete button in the same form as the edit and update. A bad idea. Now, deleting a Section is handled in it's own independent form, rather than attempting to rewrite the forms hidden `_method` field to trick Rails into doing a destroy. This is also better from a design perspective because: A) omg, a delete button so close to the save button is DANGEROUS B) Deleting a Section is kinda a big deal, and while it would be better to bubble-wrap the heck out of it so people who *do* delete a section don't wind up in a sad-mad state; we can at least give them lots of "DANGER WILL ROBINSON DANGER" messaging. This is... irresponsible of us but what we can do now. If a motivated bystander or contributor wanted to design and implement a way for Sections to be Archived instead; I would be Very Happy ™️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Section: Cannot be removed #1841So, this was caused by me being FANCY and putting the delete button in the same form as the edit and update. A bad idea.
Now, deleting a Section is handled in it's own independent form, rather than attempting to rewrite the forms hidden
_methodfield to trick Rails into doing a destroy.This is also better from a design perspective because:
A) omg, a delete button so close to the save button is DANGEROUS
B) Deleting a Section is kinda a big deal, and while it would be better to bubble-wrap the heck out of it so people who do delete a section don't wind up in a sad-mad state; we can at least give them lots of "DANGER WILL ROBINSON DANGER" messaging.
This is... irresponsible of us but what we can do now. If a motivated bystander or contributor wanted to design and implement a way for Sections to be Archived instead; I would be Very Happy ™️