Skip to content

Commit

Permalink
🛠️ Gizmos: Gizmos that don't use S3 shouldn't fail w/o AWS
Browse files Browse the repository at this point in the history
We initialize `active-storage` and `aws-sdk-s3` when we load the
application code, which loads up `config/storage.yml` and sets up an AWS
S3 Client.

But the `Journal` doesn't use AWS S3, so the continuous integration
environment doesn't have AWS credentials!

I *could* add credentials to the Journal Gizmo's CI environment, but
that would mean other Gizmos that don't use AWS S3 would need AWS
credentials

So I'm going to add some fake test credentials to the .env.test.example
file, which should let the AWS S3 client initialize and then explode
horribly when we try and shovel some data into it.
  • Loading branch information
zspencer committed Jan 29, 2024
1 parent 19bd3fe commit d4cc793
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
4 changes: 4 additions & 0 deletions .env.test.example
Original file line number Diff line number Diff line change
Expand Up @@ -2,3 +2,7 @@
MARKETPLACE_VENDOR_STRIPE_ACCOUNT=acct_GET_THIS_FROM_STRIPE
MARKETPLACE_VENDOR_SQUARE_ACCESS_TOKEN=GET_THIS_FROM_SQUARE
MARKETPLACE_VENDOR_SQUARE_LOCATION_ID=GET_THIS_FROM_SQUARE

AWS_S3_ACCESS_KEY_ID="GET_THIS_FROM_AWS"
AWS_S3_SECRET_ACCESS_KEY="GET_THIS_FROM_AWS"
AWS_S3_BUCKET="GET_THIS_FROM_AWS"
3 changes: 0 additions & 3 deletions .github/workflows/test-convene-journal.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,6 @@ env:
REDIS_HOST: redis
REDIS_PORT: 6379
HEADLESS: true
AWS_S3_ACCESS_KEY_ID: ${{ secrets.AWS_S3_ACCESS_KEY_ID }}
AWS_S3_SECRET_ACCESS_KEY: ${{ secrets.AWS_S3_SECRET_ACCESS_KEY }}
AWS_S3_BUCKET: ${{ secrets.AWS_S3_BUCKET }}

jobs:
setup:
Expand Down

0 comments on commit d4cc793

Please sign in to comment.