Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let Sinopé thermostat and light quirks inherit from CustomDevice #3542

Merged
merged 3 commits into from
Nov 25, 2024

Conversation

claudegel
Copy link
Contributor

Proposed change

  • All devices class should inherit from CustomDevice.
  • Small fix for SinopeHPThermostats for devices list

Additional information

Checklist

  • The changes are tested and work correctly
  • pre-commit checks pass / the code has been formatted using Black
  • Tests have been added to verify that the new code works

Copy link

codecov bot commented Nov 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.61%. Comparing base (f239f30) to head (530f900).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #3542   +/-   ##
=======================================
  Coverage   89.61%   89.61%           
=======================================
  Files         313      313           
  Lines       10218    10218           
=======================================
  Hits         9157     9157           
  Misses       1061     1061           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Collaborator

@TheJulianJES TheJulianJES left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@TheJulianJES TheJulianJES added the code quality Improvement to code quality label Nov 25, 2024
@TheJulianJES TheJulianJES changed the title Sinopé thermostat and light devices class should inherit from CustomDevice Let Sinopé thermostat and light quirks inherit from CustomDevice Nov 25, 2024
@TheJulianJES TheJulianJES merged commit 77c05e7 into zigpy:dev Nov 25, 2024
9 checks passed
@claudegel claudegel deleted the CustomDevice branch November 25, 2024 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code quality Improvement to code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants