[test] Append only table can't test failing IO re-insert yet (apache#…

…3089)
zhuangchong · Mar 26, 2024 · ea91033 · ea91033
1 parent 8372415
commit ea91033
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/...link-common/src/test/java/org/apache/paimon/flink/UnawareBucketAppendOnlyTableITCase.java b/...link-common/src/test/java/org/apache/paimon/flink/UnawareBucketAppendOnlyTableITCase.java
@@ -242,6 +242,7 @@ public void testTimestampLzType() {
                                         .toInstant()));
     }
 
+    // test is not correct, append table may insert twice if always retry when file io fails
     @Test
     public void testReadWriteFailRandom() throws Exception {
         setFailRate(100, 1000);
@@ -265,7 +266,7 @@ public void testReadWriteFailRandom() throws Exception {
                 () -> {
                     batchSql("SELECT * FROM append_table");
                     List<Row> rows = batchSql("SELECT * FROM append_table");
-                    assertThat(rows.size()).isEqualTo(size);
+                    assertThat(rows.size()).isGreaterThanOrEqualTo(size);
                     assertThat(rows).containsExactlyInAnyOrder(results.toArray(new Row[0]));
                 });
     }
@@ -294,7 +295,7 @@ public void testReadWriteFailRandomString() throws Exception {
                 () -> {
                     batchSql("SELECT * FROM append_table");
                     List<Row> rows = batchSql("SELECT * FROM append_table");
-                    assertThat(rows.size()).isEqualTo(size);
+                    assertThat(rows.size()).isGreaterThanOrEqualTo(size);
                     assertThat(rows).containsExactlyInAnyOrder(results.toArray(new Row[0]));
                 });
     }