Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip command table node set on empty value #23

Merged
merged 4 commits into from
Dec 18, 2023

Conversation

markheik
Copy link
Collaborator

@markheik markheik commented Nov 30, 2023

This PR fixes an issue where LabOne error log showed that command table cannot be uploaded before ELF, even though no command table is not defined.

Currently when command table file path value is empty, an empty command table is sent to the device. Historically this was used to reset the command table.

However, this produces an error in LabOne DataServer log, that ELF must be loaded first, even though a command table was never meant to be uploaded. If command table must be reset, it should be done via appropriate node: ../commandtable/clear


It also ensures that enumerated node values are called with an integer, not string

@markheik markheik self-assigned this Nov 30, 2023
@codecov-commenter
Copy link

codecov-commenter commented Nov 30, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (45aeed3) 98.66% compared to head (cb1e284) 98.67%.

Files Patch % Lines
src/zhinst/labber/driver/base_instrument.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #23   +/-   ##
=======================================
  Coverage   98.66%   98.67%           
=======================================
  Files          12       12           
  Lines        1126     1128    +2     
=======================================
+ Hits         1111     1113    +2     
  Misses         15       15           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@tobiasah tobiasah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@markheik markheik merged commit 3529920 into main Dec 18, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants