Add support for configurable subscriptions #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabiorossetto
force-pushed
the
fabior/configurable_sub
branch
from
9fadee8 to
6eff7e6
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #73 +/- ##
==========================================
- Coverage 90.12% 89.96% -0.17%
==========================================
Files 25 25
Lines 2097 2113 +16
Branches 91 91
==========================================
+ Hits 1890 1901 +11
- Misses 199 204 +5
Partials 8 8 ☔ View full report in Codecov by Sentry. |
fabiorossetto
force-pushed
the
fabior/configurable_sub
branch
from
6eff7e6 to
f220d9a
Compare
Add "kwargs" to the "subscribe" method to allow the forwarding of configurations to the data-server. This feature is needed to allow the configuration of the severity level when subscribing to the "/zi/debug/log" node.
fabiorossetto
force-pushed
the
fabior/configurable_sub
branch
from
f220d9a to
f91c3a6
Compare
tobiasah
approved these changes
Nov 12, 2024
| * `subscribe` accepts keyword arguments, which are forwarded to the data-server. | ||
| This allows to configure the subscription to the data-server. | ||
| Note that as of LabOne 24.10, no node supports yet subscription configuration. | ||
|
|
||
| ## Version 3.1.2 |
There was a problem hiding this comment.
suggestion: If we do not release a separate version 3.1.2 I would just merge it with 3.2.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add "kwargs" to the "subscribe" method to allow the forwarding of configurations to the data-server. This feature is needed to allow the configuration of the severity level when subscribing to the "/zi/debug/log" node.