Adapt server to support close and run forever #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #67 +/- ##
==========================================
- Coverage 95.81% 94.26% -1.56%
==========================================
Files 26 26
Lines 1433 1464 +31
Branches 230 235 +5
==========================================
+ Hits 1373 1380 +7
- Misses 48 72 +24
Partials 12 12 ☔ View full report in Codecov by Sentry. |
This commit adapts the capnp server class to support the close method and run forever method. The close method is used to stop a running server safely. Since Python does not gurantee that the destructor is called it is recommended to manage the livetime by one self. The run forever method is a simple helper function that is often usefull if a server is running in the main thread.
tobiasah
force-pushed
the
tobiasa/server_adaptions
branch
from
afc5769
to
c92008f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adapts the capnp server class to support the close method and run forever method. The close method is used to stop a running server safely. Since Python does not gurantee that the destructor is called it is recommended to manage the livetime by one self. The run forever method is a simple helper function that is often usefull if a server is running in the main thread.