Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt backend to custom zhinst.comms package #63

Merged
merged 1 commit into from
Jun 13, 2024
Merged

Conversation

tobiasah
Copy link
Member

This commit replaces the dependency to pycapnp with zhinst.comms. This
fixes the stability issues we had before and also allows us to simplify
the python code.

@tobiasah tobiasah self-assigned this Jun 13, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jun 13, 2024

Codecov Report

Attention: Patch coverage is 88.64353% with 36 lines in your changes missing coverage. Please review.

Project coverage is 95.81%. Comparing base (7cf3492) to head (afc3798).

Files Patch % Lines
src/labone/core/subscription.py 64.10% 12 Missing and 2 partials ⚠️
src/labone/core/session.py 88.88% 7 Missing and 1 partial ⚠️
src/labone/server/server.py 83.78% 4 Missing and 2 partials ⚠️
src/labone/core/value.py 88.88% 3 Missing and 2 partials ⚠️
src/labone/core/kernel_session.py 88.23% 1 Missing and 1 partial ⚠️
src/labone/server/session.py 98.14% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #63      +/-   ##
==========================================
- Coverage   99.26%   95.81%   -3.46%     
==========================================
  Files          34       26       -8     
  Lines        1915     1432     -483     
  Branches      295      230      -65     
==========================================
- Hits         1901     1372     -529     
- Misses         14       48      +34     
- Partials        0       12      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This commit replaces the dependency to pycapnp with zhinst.comms. This
fixes the stability issues we had before and also allows us to simplify
the python code.
@tobiasah tobiasah merged commit f452a3e into main Jun 13, 2024
10 checks passed
@tobiasah tobiasah deleted the custom_backend branch September 19, 2024 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants