Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt mock to utilize the new schema generation #55

Merged
merged 1 commit into from
Feb 8, 2024

Conversation

tobiasah
Copy link
Member

@tobiasah tobiasah commented Feb 4, 2024

This commit adapts the mock to utilize the new schema generation. Pycapnp is not able to provide the node schema as requiered by the reflection schema. Therefore we have written a small script to generate the schema in c++ and export it to bytes-packed. The scripts creates a python module. The module hpk_schema is hardcoded.

@tobiasah tobiasah self-assigned this Feb 4, 2024
@codecov-commenter
Copy link

codecov-commenter commented Feb 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (918fe08) 100.00% compared to head (e86f11d) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #55   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           32        33    +1     
  Lines         1908      1910    +2     
  Branches       294       294           
=========================================
+ Hits          1908      1910    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tobiasah tobiasah force-pushed the tobiasa/adapt_mock branch 2 times, most recently from 831e9a6 to e86f11d Compare February 7, 2024 06:47
@tobiasah tobiasah requested a review from markheik February 7, 2024 06:48
Copy link
Collaborator

@markheik markheik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGT

This commit adapts the mock to utilize the new schema generation.
Pycapnp is not able to provide the node schema as requiered by
the reflection schema. Therefore we have written a small script
to generate the schema in c++ and export it to bytes-packed.
The scripts creates a python module. The module `hpk_schema` is
hardcoded.
@tobiasah tobiasah merged commit a8b3d51 into main Feb 8, 2024
1 check passed
@tobiasah tobiasah deleted the tobiasa/adapt_mock branch September 19, 2024 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants