chore: use defer and add comments

zhijie-yang · Nov 27, 2024 · 4da7024 · 4da7024
1 parent f903c25
commit 4da7024
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/internal/deb/extract.go b/internal/deb/extract.go
@@ -136,6 +136,7 @@ func extractData(pkgReader io.ReadSeeker, options *ExtractOptions) error {
 	if err != nil {
 		return err
 	}
+	defer dataReader.Close()
 
 	oldUmask := syscall.Umask(0)
 	defer func() {
@@ -338,8 +339,6 @@ func extractData(pkgReader io.ReadSeeker, options *ExtractOptions) error {
 		}
 	}
 
-	dataReader.Close()
-
 	return nil
 }
 

diff --git a/internal/fsutil/create.go b/internal/fsutil/create.go
@@ -77,6 +77,7 @@ func Create(options *CreateOptions) (*Entry, error) {
 		return nil, err
 	}
 	mode := s.Mode()
+	// Overrides mode if the entry is not a link and the mode differs.
 	if o.OverrideMode && mode != o.Mode && o.Link == "" {
 		err := os.Chmod(o.Path, o.Mode)
 		if err != nil {