partition name

zhangstar333 · Dec 1, 2023 · 998c779 · 998c779
1 parent d00c9d9
commit 998c779
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 4 deletions.
diff --git a/be/src/vec/sink/vrow_distribution.cpp b/be/src/vec/sink/vrow_distribution.cpp
@@ -45,7 +45,6 @@ Status VRowDistribution::_save_missing_values(const std::vector<std::vector<std:
                                               std::vector<int64_t> filter) {
     // de-duplication for new partitions but save all rows.
     _batching_block->add_rows(block, filter);
-    _partitions_need_create.clear();
     std::vector<TStringLiteral> cur_row_values;
     for (int row = 0; row < col_strs[0].size(); ++row) {
         cur_row_values.clear();

diff --git a/fe/fe-core/src/main/java/org/apache/doris/analysis/PartitionExprUtil.java b/fe/fe-core/src/main/java/org/apache/doris/analysis/PartitionExprUtil.java
@@ -34,6 +34,7 @@
 import java.util.HashSet;
 import java.util.List;
 import java.util.Map;
+import java.util.Objects;
 import java.util.Set;
 
 public class PartitionExprUtil {
@@ -131,8 +132,9 @@ public static Map<String, AddPartitionClause> getAddPartitionClauseFromPartition
             for (TStringLiteral tStringLiteral : partitionValueList) {
                 curPartitionValues.add(tStringLiteral.value);
             }
-            // combine value with '_', eg: "abc_123", but maybe have error
-            String filterStr = String.join("_", curPartitionValues);
+            String filterStr = curPartitionValues.stream()
+                    .map(s -> s + s.length()) // Concatenate each string with its length
+                    .reduce("", (s1, s2) -> s1 + s2);
             if (filterPartitionValues.contains(filterStr)) {
                 continue;
             }
@@ -156,7 +158,9 @@ public static Map<String, AddPartitionClause> getAddPartitionClauseFromPartition
                         listValues);
                 partitionName += getFormatPartitionValue(filterStr);
                 if (partitionColumnType.isStringType()) {
-                    partitionName += "_" + System.currentTimeMillis();
+                    if (partitionName.length() > 50) {
+                        partitionName = partitionName.substring(40) + Objects.hash(partitionName) + "_" + System.currentTimeMillis();
+                    }
                 }
             } else {
                 throw new AnalysisException("now only support range and list partition");