Skip to content

Commit

Permalink
[improve](join) remove join probe dependency of wait rf
Browse files Browse the repository at this point in the history
  • Loading branch information
zhangstar333 committed Jan 10, 2024
1 parent c1a2734 commit 8befa64
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 8 deletions.
1 change: 0 additions & 1 deletion be/src/pipeline/exec/hashjoin_build_sink.h
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@ class HashJoinBuildSink final : public StreamingOperator<vectorized::HashJoinNod
public:
HashJoinBuildSink(OperatorBuilderBase* operator_builder, ExecNode* node);
bool can_write() override { return _node->can_sink_write(); }
bool is_pending_finish() const override { return !_node->ready_for_finish(); }
};

class HashJoinBuildSinkOperatorX;
Expand Down
7 changes: 0 additions & 7 deletions be/src/vec/exec/join/vhash_join_node.h
Original file line number Diff line number Diff line change
Expand Up @@ -244,13 +244,6 @@ class HashJoinNode final : public VJoinNodeBase {

bool should_build_hash_table() const { return _should_build_hash_table; }

bool ready_for_finish() {
if (_runtime_filter_slots == nullptr) {
return true;
}
return _runtime_filter_slots->ready_finish_publish();
}

bool have_other_join_conjunct() const { return _have_other_join_conjunct; }
bool is_right_semi_anti() const { return _is_right_semi_anti; }
bool is_outer_join() const { return _is_outer_join; }
Expand Down

0 comments on commit 8befa64

Please sign in to comment.