[Bug](udf) java-udf function open failed cause BE core dump apache#28063

when the java-udf open function failed, and some JNI have not set, so in close function can't call jni.
zhangstar333 · Dec 15, 2023 · 6591676 · 6591676
1 parent bde9dc9
commit 6591676
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/be/src/vec/functions/function_java_udf.cpp b/be/src/vec/functions/function_java_udf.cpp
@@ -119,6 +119,7 @@ Status JavaFunctionCall::open(FunctionContext* context, FunctionContext::Functio
         }
         RETURN_ERROR_IF_EXC(env);
         RETURN_IF_ERROR(JniUtil::LocalToGlobalRef(env, jni_ctx->executor, &jni_ctx->executor));
+        jni_ctx->open_successes = true;
     }
     return Status::OK();
 }

diff --git a/be/src/vec/functions/function_java_udf.h b/be/src/vec/functions/function_java_udf.h
@@ -144,11 +144,16 @@ class JavaFunctionCall : public IFunctionBase {
         jmethodID executor_close_id_;
         jobject executor = nullptr;
         bool is_closed = false;
+        bool open_successes = false;
 
         JniContext(int64_t num_args, jclass executor_cl, jmethodID executor_close_id)
                 : executor_cl_(executor_cl), executor_close_id_(executor_close_id) {}
 
         void close() {
+            if (!open_successes) {
+                LOG_WARNING("maybe open failed, need check the reason");
+                return; //maybe open failed, so can't call some jni
+            }
             if (is_closed) {
                 return;
             }