fix multiplied critical output by setting atRule as container

zgreen · May 30, 2017 · 087b077 · 087b077
1 parent a59a90f
commit 087b077
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 12 deletions.
diff --git a/lib/getCriticalRules.js b/lib/getCriticalRules.js
@@ -71,11 +71,12 @@ function correctSourceOrder(root) {
  * @return {Object} A new root node with an atrule at its base.
  */
 function establishContainer(node) {
-  return node.parent.type === 'atrule' && node.parent.name !== 'critical' ? updateCritical(_postcss2.default.atRule({
+  return node.parent.type === 'atrule' && node.parent.name !== 'critical' ? _postcss2.default.atRule({
     name: node.parent.name,
     type: node.parent.type,
-    params: node.parent.params
-  }), node) : node.clone();
+    params: node.parent.params,
+    nodes: [node]
+  }) : node.clone();
 }
 
 /**

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "postcss-critical-css",
-  "version": "2.1.3",
+  "version": "2.1.4",
   "description": "Generate critical CSS using PostCSS",
   "main": "index.js",
   "repository": {

diff --git a/src/getCriticalRules.js b/src/getCriticalRules.js
@@ -63,14 +63,12 @@ function correctSourceOrder (root: Object): Object {
  */
 function establishContainer (node: Object): Object {
   return node.parent.type === 'atrule' && node.parent.name !== 'critical'
-    ? updateCritical(
-        postcss.atRule({
-          name: node.parent.name,
-          type: node.parent.type,
-          params: node.parent.params
-        }),
-        node
-      )
+    ? postcss.atRule({
+      name: node.parent.name,
+      type: node.parent.type,
+      params: node.parent.params,
+      nodes: [node]
+    })
     : node.clone()
 }