Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ErfExp pdf #67

Merged
merged 10 commits into from
Mar 23, 2024
Merged

feat: add ErfExp pdf #67

merged 10 commits into from
Mar 23, 2024

Conversation

ikrommyd
Copy link
Contributor

@ikrommyd ikrommyd commented Mar 22, 2024

Add ErfExp PDF which is a product of a complementary error function and an exponential

Proposed Changes

  • added zfit_physics/models/pdf_erfexp.py

Tests added

  • added tests/test_pdf_erfexp.py

Checklist

  • change approved
  • implementation finished
  • correct namespace imported
  • tests added
  • CHANGELOG updated

@ikrommyd ikrommyd requested a review from jonas-eschle March 22, 2024 16:14
Copy link
Contributor

@jonas-eschle jonas-eschle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some comments (other duties right now), back on it later

CHANGELOG.rst Outdated Show resolved Hide resolved
tests/test_pdf_erfexp.py Outdated Show resolved Hide resolved
tests/test_pdf_erfexp.py Show resolved Hide resolved
zfit_physics/models/pdf_erfexp.py Outdated Show resolved Hide resolved
zfit_physics/models/pdf_erfexp.py Show resolved Hide resolved
@ikrommyd ikrommyd requested a review from jonas-eschle March 22, 2024 22:35
@ikrommyd
Copy link
Contributor Author

@jonas-eschle done with the changes. Will merge if you approve.

Copy link
Contributor

@jonas-eschle jonas-eschle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All fine, LGTM!

@jonas-eschle jonas-eschle enabled auto-merge March 23, 2024 20:10
@jonas-eschle jonas-eschle merged commit cf041b0 into develop Mar 23, 2024
12 checks passed
@ikrommyd ikrommyd deleted the ikrommyd/feat-erfexp branch March 23, 2024 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants