fix: do ECClient disconnect in RTCIceConnectionStateClosed only to prevent crash. #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
And so far I couldn't reproduce the crash on your sample code yet. |
|
thanks @allenlinli! I'll hope to be back on this project next week and review/test all these. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found a bug that it crashes when I disconnect a room.
The bug is described in the issue I sent earlier: #74
I found the reason it crashes is that a block inside ECClient is being released when the ECClient is released(while ECRoom's
publishingStatsTimerreleased, and so that ECRoom and ECClient are released).So I move the
disconnectto RTCIceConnectionStateClosed to prevent this crash.And after I read the references addressed in this issue (#73), I still didn't find the answer that should both
RTCIceConnectionStateDisconnectedandRTCIceConnectionStateCloseddodisconnect. Since disconnect deallocatesECRoom, and it "probably" always callsRTCIceConnectionStateClosed, we could safely calldisconnectatRTCIceConnectionStateClosed.