Removed dependencies on ConnectionGrain in GroupGrain and UserGrain #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o make it easier to make new changes. Removed ConnectionGrain because it is no longer needed
|
Another reason ConnectionGrain doesn't make sense, is that ConnectionGrain indicates its purpose is to handle one connection only, not many. Perhaps ClientGrain should be called ConnectionGrain? |
|
This all makes sense. I'm good with Renaming ClientGrain to ConnectionGrain, or even call it ClientConnectionGrain. |
zeus82
approved these changes
Oct 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GroupGrain and UserGrain were both inheriting from the abstract ConnectionGrain. To make it easier to make changes without affecting other grains, the ConnectionGrain base class has been removed and the logic copied into GroupGrain and UserGrain.
This opens up additional improvements for how to handle groups and minimize number of necessary streams used by the streams