Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Permet d'écrire des billets ou articles avec une structure de tutoriel #6550

Merged
merged 11 commits into from
Sep 9, 2024
Merged

Permet d'écrire des billets ou articles avec une structure de tutoriel #6550

merged 11 commits into from
Sep 9, 2024

Conversation

Arnaud-D
Copy link
Contributor

Je continue à découper #6441.

Cette PR permet de créer des billets et articles avec des conteneurs imbriqués, comme pour les tutos. J'ajoute aussi les routes associées, histoire qu'on puisse effectivement lire tout ça. :D

Contrôle qualité

  • Créer des articles et billets avec une structure de tuto (parties, chapitres...).
  • Tester la publication, la dépublication, la validation, la mise en bêta, etc.
  • Se promener sur les pages publiques, brouillon, beta (pour les articles) et voir si on peut accéder à tout. Normalement seules les pages publiques ont des URL particulières (les autres sont en /contenus/).

@Arnaud-D Arnaud-D added C-Back Concerne le back-end Django hacktoberfest-accepted Pull request approuvée pour le Hacktoberfest labels Oct 28, 2023
@coveralls
Copy link

coveralls commented Oct 28, 2023 •
edited
Loading

Coverage Status

coverage: 88.887% (+0.008%) from 88.879%
when pulling 0373dfa on Arnaud-D:structure-tuto-pour-billet-et-article
into cefa2cb on zestedesavoir:dev.

philippemilink
philippemilink requested changes Nov 1, 2023
View reviewed changes
Copy link
Member

@philippemilink philippemilink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Le découpage que tu fais dans les fichiers zds/tutorialv2/urls/urls_opinions.py et zds/tutorialv2/urls/urls_articles.py est bien, mais par souci de cohérence, ce serait bien de le faire aussi dans zds/tutorialv2/urls/urls_tutorials.py.

zds/tutorialv2/models/versioned.py Outdated Show resolved Hide resolved
@Arnaud-D Arnaud-D force-pushed the structure-tuto-pour-billet-et-article branch 2 times, most recently from 8c1cd49 to 86b0dbf Compare December 9, 2023 18:15
@Arnaud-D
Copy link
Contributor Author

Arnaud-D commented Dec 9, 2023

J'ai fait les modifs.

@Arnaud-D Arnaud-D force-pushed the structure-tuto-pour-billet-et-article branch from 86b0dbf to 0c65fce Compare December 10, 2023 18:16
@Arnaud-D Arnaud-D force-pushed the structure-tuto-pour-billet-et-article branch from 0c65fce to 98a722c Compare February 24, 2024 06:33
@Arnaud-D Arnaud-D force-pushed the structure-tuto-pour-billet-et-article branch 3 times, most recently from f7e8396 to b11678f Compare March 9, 2024 09:58
@Arnaud-D Arnaud-D force-pushed the structure-tuto-pour-billet-et-article branch from b11678f to 8152adf Compare March 16, 2024 08:42
@Arnaud-D Arnaud-D force-pushed the structure-tuto-pour-billet-et-article branch from 8152adf to 7e1d037 Compare March 29, 2024 21:53
philippemilink
philippemilink requested changes Apr 28, 2024
View reviewed changes
Copy link
Member

@philippemilink philippemilink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Je n'ai pas testé, mais encore quelques petites remarques sur le code. Il faudrait aussi mettre à jour la documentation, par exemple ici.

zds/tutorialv2/models/versioned.py Outdated Show resolved Hide resolved
zds/tutorialv2/models/versioned.py Outdated Show resolved Hide resolved
zds/tutorialv2/tests/tests_routes.py Show resolved Hide resolved
zds/tutorialv2/tests/tests_routes.py Show resolved Hide resolved
@Arnaud-D Arnaud-D force-pushed the structure-tuto-pour-billet-et-article branch 3 times, most recently from 467f3e6 to aa38e15 Compare April 28, 2024 18:47
@Arnaud-D Arnaud-D force-pushed the structure-tuto-pour-billet-et-article branch 2 times, most recently from a863fb6 to f0faa76 Compare April 28, 2024 19:37
@Arnaud-D Arnaud-D self-assigned this Jun 9, 2024
philippemilink
philippemilink requested changes Sep 7, 2024
View reviewed changes
doc/source/back-end/contents.rst Outdated Show resolved Hide resolved
@philippemilink
Copy link
Member

Il faudrait aussi changer les fixtures pour générer des articles et billets avec les différentes structures qui sont maintenant possibles. A priori il suffit de modifier la condition de cette ligne :

zds-site/zds/utils/management/commands/load_fixtures.py

Line 579 in cefa2cb

if current_size == 0 or is_articles or is_opinion:

@Arnaud-D Arnaud-D force-pushed the structure-tuto-pour-billet-et-article branch from f0faa76 to 64c8db9 Compare September 8, 2024 11:05
@Arnaud-D
Copy link
Contributor Author

Arnaud-D commented Sep 8, 2024

Il faudrait aussi changer les fixtures pour générer des articles et billets avec les différentes structures qui sont maintenant possibles.

C'est fait aussi. J'en ai profité pour refactoriser un tout petit peu.

@Arnaud-D Arnaud-D force-pushed the structure-tuto-pour-billet-et-article branch from 64c8db9 to 86d38e5 Compare September 8, 2024 11:06
philippemilink
philippemilink requested changes Sep 8, 2024
View reviewed changes
Copy link
Member

@philippemilink philippemilink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rapport de QA OK ✔️

La petite modification de commentaire et on fusionne.

zds/utils/management/commands/load_fixtures.py Outdated
if current_size == 1: # medium size tutorial
for k in range(random.randint(1, nb_avg_extracts_in_content * 2)):
ExtractFactory(container=container, title=fake.text(max_nb_chars=60), light=False)
if size == 1: # medium size tutorial
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if size == 1: # medium size tutorial
if size == 1: # medium size content

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fait.

zds/utils/management/commands/load_fixtures.py Outdated Show resolved Hide resolved
@philippemilink philippemilink mentioned this pull request Sep 8, 2024
Merged
@Arnaud-D Arnaud-D enabled auto-merge (squash) September 9, 2024 17:02
@philippemilink philippemilink merged commit 29b75e0 into zestedesavoir:dev Sep 9, 2024
12 checks passed
@Arnaud-D Arnaud-D deleted the structure-tuto-pour-billet-et-article branch September 9, 2024 20:04
@philippemilink philippemilink mentioned this pull request Sep 25, 2024
Merged
This was referenced Oct 30, 2024
Open
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philippemilink philippemilink philippemilink approved these changes

Assignees

@Arnaud-D Arnaud-D

Labels
C-Back Concerne le back-end Django hacktoberfest-accepted Pull request approuvée pour le Hacktoberfest
Projects
Suivi des PR
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Arnaud-D @coveralls @philippemilink