Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix (servicePush.go): push without a flag provided #194

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

dinxsh
Copy link
Contributor

@dinxsh dinxsh commented Nov 12, 2024

What Type of Change is this?

  • New Feature
  • Fix
  • Improvement
  • Other

Description

The current usage for zcli push --serviceId is zcli push --serviceId z3eHIXPjT0iKAIZATAqg4g
which pushes the code to the service which then gets built and deployed

was required to implement zcli push z3eHIXPjT0iKAIZATAqg4g without a flag

made both cases work

  1. zcli push --serviceId z3eHIXPjT0iKAIZATAqg4g

  2. zcli push z3eHIXPjT0iKAIZATAqg4g

used references and implementation from zcli vpn up in vpnUp.go

Related issues & labels (optional)

@l-hellmann l-hellmann merged commit 8ba09a6 into zeropsio:main Nov 12, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants