Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: git ls-files command output quoting on 'unusual' characters #151

Merged
merged 1 commit into from
May 29, 2024
Merged

fix: git ls-files command output quoting on 'unusual' characters #151

merged 1 commit into from
May 29, 2024

Conversation

l-hellmann
Copy link
Collaborator

@l-hellmann l-hellmann commented May 28, 2024 •
edited
Loading

fixes output of git ls-files command quoting "unusual" ('bytes higher than 0x80' - git config 'core.quotePath' manpage) characters

@l-hellmann l-hellmann force-pushed the fix-git-ls-cmd-output branch from 7fe7ee0 to 926f5b3 Compare May 28, 2024 22:00
@l-hellmann l-hellmann requested a review from MichalSalon May 29, 2024 08:40
MichalSalon
MichalSalon previously requested changes May 29, 2024
View reviewed changes
Copy link
Collaborator

@MichalSalon MichalSalon left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you, please, add one such file to the folder with tests? Just to have it covered.

Something with em-dash, en-dash or similar non-ascii symbols.

@l-hellmann l-hellmann force-pushed the fix-git-ls-cmd-output branch from 926f5b3 to b217475 Compare May 29, 2024 16:19
@l-hellmann l-hellmann force-pushed the fix-git-ls-cmd-output branch from b217475 to 65ec888 Compare May 29, 2024 16:20
@l-hellmann l-hellmann requested a review from MichalSalon May 29, 2024 16:21
@l-hellmann l-hellmann dismissed MichalSalon’s stale review May 29, 2024 17:49

tikinang approved

@l-hellmann l-hellmann merged commit 3d8ff2c into main May 29, 2024
5 checks passed
@l-hellmann l-hellmann deleted the fix-git-ls-cmd-output branch May 29, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tikinang tikinang tikinang approved these changes

@MichalSalon MichalSalon Awaiting requested review from MichalSalon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@l-hellmann @tikinang @MichalSalon