Problem: CZMQ doesn't build with MSVC without DRAFT_API definition #1325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Solution: Add DRAFT_API defs
sappo
added a commit
that referenced
this pull request
Jan 26, 2016
Problem: CZMQ doesn't build with MSVC without DRAFT_API definition
|
@keent is msvc capable of setting a define using some kind of switch. Because your solution is only a workaround and must be manually applied to all zproject based projects. It would be nice to solve this issue in zproject itself. |
|
@sappo I will try to learn zproject. I talk to Pieter about this zeromq/filemq#67 and he said - for now to apply the fix by hand and he'll backport it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution: Add DRAFT_API defs