Merge pull request #188 from aboseley/bugfix-handling-zmq_ctx_set-result

context_ops: fix bug handling zmq_ctx_set result
zeromq · Nov 8, 2021 · 92ff7ff · 92ff7ff
2 parents 810d888 + a7e7d0d
commit 92ff7ff
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/azmq/detail/context_ops.hpp b/azmq/detail/context_ops.hpp
@@ -53,7 +53,7 @@ namespace detail {
                                                     boost::system::error_code & ec) {
             BOOST_ASSERT_MSG(ctx, "context must not be null");
             auto rc = zmq_ctx_set(ctx.get(), option.name(), option.value());
-            if (!rc)
+            if (rc < 0)
                 ec = make_error_code();
             return ec;
         }

diff --git a/test/context_ops/main.cpp b/test/context_ops/main.cpp
@@ -39,3 +39,12 @@ TEST_CASE( "context_options", "[context]" ) {
     REQUIRE(!ec);
     REQUIRE(res.value() == 2);
 }
+
+TEST_CASE( "invalid option", "[context]" ) {
+  auto ctx = azmq::detail::context_ops::get_context();
+  using io_threads = azmq::detail::context_ops::io_threads;
+  boost::system::error_code ec;
+  azmq::detail::context_ops::set_option(ctx, io_threads(-1), ec);
+  REQUIRE(ec);
+  REQUIRE(ec.value() == EINVAL);
+}