feat: incorrect impl of 'assertNotEquals' on the test suite

zero/ifc/test-suite/assertions.cppm

@@ -5,8 +5,8 @@ import concepts;
 
 using namespace zero::concepts;
 
-template <Printable T, Printable U>
-constexpr inline void throw_on_failed_test(const T& expected, const U& actual);
+template <Printable T, Printable U, typename Op>
+constexpr inline void throw_on_failed_test(const T& expected, const U& actual, const Op& comp);
 
 export {
     /// @brief Compares two values. Generates a test failed if values are non-equal.
@@ -15,7 +15,7 @@ export {
     template<typename T, typename U>
         requires (!std::is_pointer_v<T> && !std::is_pointer_v<U>)
     constexpr void assertEquals(const T& expected, const U& actual) {
-        ::throw_on_failed_test(expected, actual);
+        ::throw_on_failed_test(expected, actual, [](auto expected, auto actual){ return expected == actual; });
     }
 
     ///  @brief Compares two values being T pointer types.
@@ -25,15 +25,15 @@ export {
         const auto expected   = *expected_ptr;
         const auto actual     = *actual_ptr;
 
-        ::throw_on_failed_test(expected, actual);
+        ::throw_on_failed_test(expected, actual, [](auto expected, auto actual){ return expected == actual; });
     }
 
 
     /// @brief Compares two values. Generates a test failed if the values are equals.
     template<typename T>
         requires (!std::is_pointer_v<T>)
     constexpr void assertNotEquals(const T& expected, const T& actual) {
-        ::throw_on_failed_test(expected, actual);
+        ::throw_on_failed_test(expected, actual, [](auto expected, auto actual){ return expected != actual; });
     }
 
 
@@ -45,7 +45,7 @@ export {
         const auto expected   = *expected_ptr;
         const auto actual     = *actual_ptr;
 
-        ::throw_on_failed_test(expected, actual);
+        ::throw_on_failed_test(expected, actual, [](auto expected, auto actual){ return expected != actual; });
     }
 }
 
@@ -67,9 +67,9 @@ public:
 
 /// \brief helper to reduce cognitive complexity,
 /// \enabled when the concept {\link @StringConvertible} is satisfied
-template<typename T, typename U>
-constexpr inline void throw_on_failed_test_str_impl(const T& expected, const U& actual) {
-    if (expected != actual) {
+template<typename T, typename U, typename Op>
+constexpr inline void throw_on_failed_test_str_impl(const T& expected, const U& actual, const Op& comp) {
+    if (!comp(expected, actual)) {
         const auto expected_str   = std::to_string(expected);
         const auto actual_str     = std::to_string(actual);
 
@@ -87,9 +87,9 @@ constexpr inline void throw_on_failed_test_str_impl(const T& expected, const U&
 
 /// \brief helper to reduce cognitive complexity,
 /// \enabled when the concept {\link @Ostreamable} is satisfied
-template<typename T, typename U>
-constexpr inline void throw_on_failed_test_oss_impl(const T& expected, const U& actual) {
-    if (expected != actual) {
+template<typename T, typename U, typename Op>
+constexpr inline void throw_on_failed_test_oss_impl(const T& expected, const U& actual, const Op& comp) {
+    if (!comp(expected, actual)) {
         std::ostringstream oss;
         oss << "Assertion failed: expected = ";
         oss << expected;
@@ -100,10 +100,10 @@ constexpr inline void throw_on_failed_test_oss_impl(const T& expected, const U&
     }
 }
 
-template <Printable T, Printable U>
-constexpr inline void throw_on_failed_test(const T& expected, const U& actual) {
+template <Printable T, Printable U, typename Op>
+constexpr inline void throw_on_failed_test(const T& expected, const U& actual, const Op& comp) {
     if constexpr (StringConvertible<T> && StringConvertible<U>)
-        throw_on_failed_test_str_impl(expected, actual);
+        throw_on_failed_test_str_impl(expected, actual, comp);
     else
-        throw_on_failed_test_oss_impl(expected, actual);
+        throw_on_failed_test_oss_impl(expected, actual, comp);
 }

zero/tests/math/numbers_tests.cpp

@@ -29,13 +29,18 @@ void numbers_tests() {
         assertEquals(10., real.number());
 
         auto real_from_integer = Real(integer);
-        assertEquals(8, real_from_integer.number());
+        assertEquals(7, real_from_integer.number());
 
         auto real_from_rational = Real(rational);
         assertEquals(rational, real_from_rational.number());
     });
 
     TEST_CASE(numbers_suite, "Testing the Numbers types equalities", [] {
+        assertEquals(Natural(1), Natural(1));
+        assertEquals(Integer(-1), Integer(-1));
+
+        assertEquals(Rational(1, 2), Rational(1, 2));
+        assertNotEquals(Rational(1, 2), Rational(2, 4));
     });
 
     TEST_CASE(numbers_suite, "Arithmetic operations with Naturals", [] {

zork_config/zork_clang.toml

@@ -9,8 +9,8 @@ cpp_compiler = "clang"
 driver_path = "clang++" # This binary is soft linked and included in our local path
 cpp_standard = "23"
 std_lib = "LIBCPP"
-std_lib_installed_dir = "/usr/local/share/libc++/v1"
-# std_lib_installed_dir = "C:/msys64/clang64/share/libc++/v1"
+# std_lib_installed_dir = "/usr/local/share/libc++/v1"
+std_lib_installed_dir = "C:/msys64/clang64/share/libc++/v1"
 extra_args = [
     '-Werror', '-Wall', '-Wpedantic', '-pedantic', '-Wextra', '-Wconversion', '-Wfloat-conversion', '-Wsign-conversion',
     '-Wshadow', '-Wnon-virtual-dtor', '-Wold-style-cast', '-Wcast-align', '-Wunused', '-Woverloaded-virtual',

zork_config/zork_windows_msvc.toml

@@ -73,6 +73,7 @@ interfaces = [
         { file = 'math/numbers/naturals.cppm', partition = { module = 'math', partition_name = 'numbers.naturals' } },
         { file = 'math/numbers/integers.cppm', partition = { module = 'math', partition_name = 'numbers.integers' } },
         { file = 'math/numbers/rationals.cppm', partition = { module = 'math', partition_name = 'numbers.rationals' } },
+        { file = 'math/numbers/reals.cppm', partition = { module = 'math', partition_name = 'numbers.reals' } },
         { file = 'math/numbers/detail.cpp', partition = { module = 'math', partition_name = 'numbers.detail', is_internal_partition = true } },
         { file = 'math/numbers/numbers.cppm', partition = { module = 'math', partition_name = 'numbers' } },
    # Root