Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#380: add check for empty repositories in DoT #389

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

Yegorov
Copy link
Contributor

@Yegorov Yegorov commented Oct 14, 2024

Closes #380

@Yegorov
Copy link
Contributor Author

Yegorov commented Oct 14, 2024

@Suban05 please review. Test fail, because this zerocracy/fbe#115 PR need merge before

Copy link
Contributor

@Suban05 Suban05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Yegorov looks good

@Yegorov
Copy link
Contributor Author

Yegorov commented Oct 15, 2024

@yegor256 please check

@yegor256 yegor256 merged commit 65d0572 into zerocracy:master Oct 15, 2024
8 checks passed
@yegor256
Copy link
Member

@Yegorov thanks!

@0crat
Copy link

0crat commented Oct 15, 2024

@Yegorov Thanks for your contribution! Here's the breakdown of your +4 points: +4 base, +0.1 for 2 hits-of-code, -4 for only 2 comments (our policy recommends at least 6). We've ensured you receive at least 4 points as per our policy. Remember, more hits-of-code and thorough code reviews can boost your points significantly. Keep the contributions coming! Your current balance stands at +140.

@0crat
Copy link

0crat commented Oct 15, 2024

@Suban05 Hey there! 👋 Thanks for your code review! You've earned +4 points this time. Here's the breakdown: +4 base points, -10 for having only 3 comments (policy suggests at least 6), and +10 to ensure you get something meaningful. Remember, more comments can boost your points next time! Your current balance is +104. Keep up the good work and aim for those bonus points! 💪

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

check empty repositories in DoT
4 participants