Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#238: calculate total number of unique active contributors #368

Merged
merged 1 commit into from
Oct 1, 2024
Merged

#238: calculate total number of unique active contributors #368

merged 1 commit into from
Oct 1, 2024

Conversation

Yegorov
Copy link
Contributor

@Yegorov Yegorov commented Sep 30, 2024

Closes #238

@Yegorov
Copy link
Contributor Author

Yegorov commented Sep 30, 2024

@Suban05 please review

Suban05
Suban05 reviewed Sep 30, 2024
View reviewed changes
Copy link
Contributor

@Suban05 Suban05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Yegorov looks good. added a small comment

judges/dimensions-of-terrain/dimensions-of-terrain.rb Outdated
active_contributors << commit.dig(:author, :id)
end
end
f.total_active_contributors = active_contributors.count { |c| !c.nil? }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Yegorov maybe it's better use compact: active_contributors.compact.count
or check for nil, when we add values to active_contributors?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Suban05 Ok, probably it is better to check at once for null. Thanks, fixed!

Suban05
Suban05 approved these changes Sep 30, 2024
View reviewed changes
Copy link
Contributor

@Suban05 Suban05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Yegorov
Copy link
Contributor Author

Yegorov commented Sep 30, 2024

@yegor256 please check

@yegor256 yegor256 merged commit ec8f47d into zerocracy:master Oct 1, 2024
8 checks passed
@yegor256
Copy link
Member

yegor256 commented Oct 1, 2024

@Yegorov thanks!

@0crat
Copy link

0crat commented Oct 1, 2024

@Suban05 Great job on the review! 🌟 You've earned +4 points: +4 base, -10 for limited comments, but +10 as a minimum reward. Your updated balance is now +138. Keep up the good work and aim for more detailed feedback next time!

@0crat
Copy link

0crat commented Oct 1, 2024

@Yegorov Hey there, awesome work on your contribution! 🚀 You've scored +10 points for this one: +4 for showing up, +9 for your 196 hits-of-code (just shy of that 200 mark!), but we had to deduct 4 because there were only 4 review comments. Remember, more review comments can boost your score next time! Keep the code coming - you're doing great! Your current balance is +176. Let's aim for even more points on your next contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Suban05 Suban05 Suban05 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

total_active_contributors into DoT
4 participants
@Yegorov @yegor256 @0crat @Suban05