Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

202: calculate total number of files #357

Merged
merged 1 commit into from
Sep 26, 2024
Merged

Conversation

Yegorov
Copy link
Contributor

@Yegorov Yegorov commented Sep 25, 2024

Closes #202

@Yegorov
Copy link
Contributor Author

Yegorov commented Sep 25, 2024

@Suban05 please review. Test fail, because this zerocracy/fbe#105 PR need merge before

Copy link
Contributor

@Suban05 Suban05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Yegorov fine!

@Yegorov
Copy link
Contributor Author

Yegorov commented Sep 25, 2024

@yegor256 please check

@yegor256 yegor256 merged commit de0bac3 into zerocracy:master Sep 26, 2024
6 of 8 checks passed
@yegor256
Copy link
Member

@Yegorov thanks!

@0crat
Copy link

0crat commented Sep 26, 2024

@Suban05 Thanks for your code review! Here's how your points were calculated: +4 base points, -10 for having only 2 comments (policy requires 6+), and +10 to meet the minimum 4-point reward. Your total for this review is +4 points, bringing your running balance to +134. Keep up the good work, and remember that more detailed reviews with 6+ comments can earn you higher rewards! 💻👍

@0crat
Copy link

0crat commented Sep 26, 2024

@Yegorov 🎉 Great work! You've earned +5 points for your contribution: +4 base, +5 for 109 hits-of-code, -4 for minimal comments. Keep up the momentum! Your current balance: +182. Looking forward to more quality submissions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

total_files into DoT
4 participants