Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#211 pull-was-merged details are not sufficient #286

Merged
merged 24 commits into from
Aug 18, 2024
Merged

Conversation

Suban05
Copy link
Contributor

@Suban05 Suban05 commented Aug 15, 2024

Added counting of comments in details

Closes #211

@Suban05
Copy link
Contributor Author

Suban05 commented Aug 15, 2024

@Yegorov please review

Copy link
Contributor

@Yegorov Yegorov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Suban05 All good, but I have a few comments

judges/github-events/github-events.rb Outdated Show resolved Hide resolved
test/judges/test-github-events.rb Outdated Show resolved Hide resolved
@Suban05
Copy link
Contributor Author

Suban05 commented Aug 15, 2024

@Yegorov fixed, thanks!

@Suban05
Copy link
Contributor Author

Suban05 commented Aug 15, 2024

@yegor256 Merge zerocracy/fbe#71 PR before
please check this pr

Copy link
Contributor

@Yegorov Yegorov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Suban05 Looks fine!

@Suban05
Copy link
Contributor Author

Suban05 commented Aug 16, 2024

@yegor256 please check

Copy link
Member

@yegor256 yegor256 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Suban05 take a look please

test/test__helper.rb Outdated Show resolved Hide resolved
@yegor256
Copy link
Member

@rultor merge

@rultor
Copy link
Contributor

rultor commented Aug 18, 2024

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit 74d0c23 into zerocracy:master Aug 18, 2024
8 checks passed
@rultor
Copy link
Contributor

rultor commented Aug 18, 2024

@rultor merge

@yegor256 Done! FYI, the full log is here (took me 25min)

@0crat
Copy link

0crat commented Aug 18, 2024

@Yegorov Great job on the review! 🌟 Your effort has earned you +9 points: +10 base, +9 for reviewing 497 hits-of-code (max +10), and -10 due to only 3 comments (policy requires 6+). Remember, more detailed feedback can boost your points next time! Your updated balance is now +392. Keep up the good work!

@0crat
Copy link

0crat commented Aug 18, 2024

@yegor256 Great job on the review! 🌟 You've earned 24 points: 10 base + 9 for reviewing 468 hits-of-code + 5 for 10 insightful comments. Your dedication is impressive! Current balance: -235. Keep up the excellent work!

@0crat
Copy link

0crat commented Aug 18, 2024

@Suban05 Thank you for your contribution! You've earned +21 points for this code submission: +15 as the base reward, and +6 for the 61 hits-of-code you wrote. This aligns with our team's policy of rewarding code contributions. Your current balance stands at +422. Keep up the good work and remember to maintain a balance between speed and quality in your future contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pull-was-merged details are not sufficient
5 participants