Skip to content

Commit

Permalink
Merge pull request #303 from Suban05/78_from_fbe
Browse files Browse the repository at this point in the history
use correct attributes of the pull request hash
  • Loading branch information
yegor256 authored Aug 22, 2024
2 parents fcb82cc + b915d38 commit e827215
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion Gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ GEM
net-http
faraday-retry (2.2.1)
faraday (~> 2.0)
fbe (0.0.57)
fbe (0.0.58)
backtrace (> 0)
decoor (> 0)
factbase (> 0)
Expand Down
2 changes: 1 addition & 1 deletion judges/github-events/github-events.rb
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ def self.comments_info(pr)
issue_comments.count { |comment| comment[:user][:id] != pr[:user][:id] },
comments_appreciated: count_appreciated_comments(pr, issue_comments, code_comments),
comments_resolved: Fbe.github_graph.resolved_conversations(
pr[:base][:login], pr[:base][:repo][:name], pr[:number]
pr[:base][:repo][:owner][:login], pr[:base][:repo][:name], pr[:number]
).count
}
end
Expand Down
2 changes: 1 addition & 1 deletion test/judges/test-github-events.rb
Original file line number Diff line number Diff line change
Expand Up @@ -905,7 +905,7 @@ def test_release_event_contributors

def test_pull_request_event_with_comments
fb = Factbase.new
load_it('github-events', fb, Judges::Options.new({ 'repositories' => 'foo/foo', 'testing' => true }))
load_it('github-events', fb, Judges::Options.new({ 'repositories' => 'zerocracy/baza', 'testing' => true }))
f = fb.query('(eq what "pull-was-merged")').each.to_a.first
assert_equal(4, f.comments)
assert_equal(2, f.comments_to_code)
Expand Down

0 comments on commit e827215

Please sign in to comment.