Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#78 fix undefined method `pull_request' for nil #79

Merged
merged 6 commits into from
Aug 22, 2024
Merged

#78 fix undefined method `pull_request' for nil #79

merged 6 commits into from
Aug 22, 2024

Conversation

Suban05
Copy link
Contributor

@Suban05 Suban05 commented Aug 21, 2024

Fixes #78

@Suban05
Copy link
Contributor Author

Suban05 commented Aug 21, 2024

@Yegorov @tank-bohr please review

Yegorov
Yegorov reviewed Aug 21, 2024
View reviewed changes
Copy link
Contributor

@Yegorov Yegorov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Suban05 there are a few comments

lib/fbe/github_graph.rb Outdated Show resolved Hide resolved
test/fbe/test_github_graph.rb Outdated Show resolved Hide resolved
test/fbe/test_github_graph.rb Outdated Show resolved Hide resolved
@Suban05
Copy link
Contributor Author

Suban05 commented Aug 21, 2024

@Yegorov fixed your comments, please check

@Suban05
Copy link
Contributor Author

Suban05 commented Aug 22, 2024

@Yegorov fixed

Yegorov
Yegorov approved these changes Aug 22, 2024
View reviewed changes
Copy link
Contributor

@Yegorov Yegorov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Suban05 great!

@Suban05
Copy link
Contributor Author

Suban05 commented Aug 22, 2024

@yegor256 fixed

@Suban05 Suban05 mentioned this pull request Aug 22, 2024
Merged
@yegor256 yegor256 merged commit a0bd7e5 into zerocracy:master Aug 22, 2024
9 checks passed
@yegor256
Copy link
Member

@Suban05 thanks!

@0crat
Copy link

0crat commented Aug 22, 2024

@tank-bohr Thanks for the review! You've earned +8 points. Your running balance is +136.

@0crat
Copy link

0crat commented Aug 22, 2024

@Yegorov 🌟 Fantastic review! You've earned 14 points: 8 base + 5 for your 11 insightful comments. Your dedication shines through! Your new balance: 435 points. Keep up the great work!

@0crat
Copy link

0crat commented Aug 22, 2024

@Suban05 Hi there! Thanks for your contribution of 83 hits-of-code. You've earned +24 points: +16 as a base reward, and +8 for the code you wrote. This aligns with our policy of awarding 0.1 points per hit-of-code, up to 16 points. Your running balance is now +456. Keep up the good work and continue submitting quality contributions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yegorov Yegorov Yegorov approved these changes

@tank-bohr tank-bohr tank-bohr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

undefined method `pull_request' for nil
5 participants
@Suban05 @yegor256 @0crat @tank-bohr @Yegorov