Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: replace reaction tray and directly open the emoji picker #2537

Merged
merged 1 commit into from
Jan 4, 2025
Merged

refactor: replace reaction tray and directly open the emoji picker #2537

merged 1 commit into from
Jan 4, 2025

Conversation

domw30
Copy link
Collaborator

@domw30 domw30 commented Jan 4, 2025

What does this do?

  • removes the common reaction tray
  • immediately opens the emoji picker instead

Why are we making this change?

  • reported issues with the common reaction tray

How do I test this?

  • run tests as usual
  • run UI and select the heart icon trigger when hovering over a menu to open the emoji picker

Key decisions and Risk Assessment:

Things to consider:

  1. How will this affect security?
  2. How will this affect performance?
  3. Does this change any APIs?

@domw30 domw30 requested a review from a team January 4, 2025 10:36
@domw30 domw30 merged commit 7086d01 into main Jan 4, 2025
5 checks passed
@domw30 domw30 deleted the refactor/remove-reaction-tray branch January 4, 2025 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@domw30