Send an image message via Matrix #1154
Conversation
| @@ -357,7 +353,7 @@ export class MessageInput extends React.Component<Properties, State> { | |||
| } | |||
|
|
|||
| get allowFileAttachment() { | |||
| return !featureFlags.enableMatrix && !this.props.isEditing; | |||
| return !this.props.isEditing; | |||
| } | |||
There was a problem hiding this comment.
Are we allowing any type of file now or just images?
There was a problem hiding this comment.
Ok, but enabling this will allow a user to select / drag any type of file, right? As in, do we need more checks to prevent other files?
There was a problem hiding this comment.
yes, it would. That request will just fail because we only support sending the images for now. I left it thinking sending files are gonna be a recent follow up. I can look into adding more checks, to only allow images to be "sent" via the UI for now. Let me know
There was a problem hiding this comment.
Did you see how it fails? What does the user experience? If they're getting ok feedback then it's fine but we can't just let things get into bad states.
There was a problem hiding this comment.
This is how it fails. I think that's an okay feedback 🤔
There was a problem hiding this comment.
How does the user know why that failed? If I were a user I'd just keep trying.
Confirm with Kelly, maybe? See if that's good enough for now?
Is there not just a way to limit the drag/drop component to certain file types or something?
There was a problem hiding this comment.
so... it was actualy pretty simple. Just needed to comment these out. 😅
added a note. We're only allowing images to be attached for now.
ratik21
force-pushed
the
ZOS-698-support-image-send
branch
from
6023ba9 to
1cf9c5f
Compare
What does this do?
Adds the ability to send an image message while matrix is enabled.
Screen.Recording.2023-11-04.at.4.20.02.AM.mov