Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add functionality to zNS SDK to support zNA resolution #120

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Add functionality to zNS SDK to support zNA resolution #120

wants to merge 4 commits into from

Conversation

deep-quality-dev
Copy link
Contributor

User Story #1047

Added two external functions:

  • getDomainResourceAssociations
  • getResourceRegistry

@deep-quality-dev deep-quality-dev requested review from RyanCross, JamesEarle and Will-Hyde and removed request for RyanCross and JamesEarle November 16, 2022 13:39
RyanCross
RyanCross previously approved these changes Nov 16, 2022
View reviewed changes
Copy link
Contributor

@RyanCross RyanCross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding some basic tests validating these endpoints. Otherwise LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RyanCross RyanCross RyanCross left review comments

@Will-Hyde Will-Hyde Awaiting requested review from Will-Hyde

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@deep-quality-dev @RyanCross