Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: scheduled deploy #203

Merged
merged 12 commits into from
Oct 8, 2024
Merged

ci: scheduled deploy #203

merged 12 commits into from
Oct 8, 2024

Conversation

nilaycicekli
Copy link
Contributor

@nilaycicekli nilaycicekli commented Sep 16, 2024

Change description

Adding a monthly scheduled deployment workflow for images to be rebuilt with security updates.

Type of change

  • Bug fix (fixes an issue)
  • New feature (adds functionality)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • Application changes have been tested thoroughly
  • Automated tests covering modified code pass

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

Code review

  • Pull request has a descriptive title and it follows conventional commit format and breaking change indicator if required (You can use the Angular convention)
  • Screenshots or screencasts are attached as necessary
  • "Ready for review" label attached and reviewers assigned
  • Changes have been reviewed by at least one other contributor
  • Pull request linked to task tracker where applicable

@nilaycicekli
Copy link
Contributor Author

could not update the base image to 16 because of dependency conflicts: #164 (comment)

Copy link
Member

@aykutbulca aykutbulca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't get why we have a separate reusable-docker-publish.yaml here (assuming it won't be used outside of this repo). Why don't we keep the content in docker-publish.yaml if we are not going to use the one in the infra repo?

Also, why don't we use the docker-publish from the infra repo? Is it because of the node version?

@nilaycicekli
Copy link
Contributor Author

Also, why don't we use the docker-publish from the infra repo? Is it because of the node version?

microsoft-teams-app is a public repo, and since infra is private, we cannot use the reusable yaml from there: https://docs.github.com/en/actions/sharing-automations/reusing-workflows#access-to-reusable-workflows

I didn't get why we have a separate reusable-docker-publish.yaml here (assuming it won't be used outside of this repo). Why don't we keep the content in docker-publish.yaml if we are not going to use the one in the infra repo?

the newly added scheduled workflow would be almost a copy of docker-publish.yaml. I put the common code in the reusable-docker-publish.yaml so that we do not duplicate the existing yaml as a better coding practice. This usage is also more aligned with our repos.

I think this approach provides cleaner code. What do you think? 👀 @aykutbulca

@nilaycicekli nilaycicekli merged commit 650241e into main Oct 8, 2024
1 check passed
@nilaycicekli nilaycicekli deleted the ci/scheduled-deploy branch October 8, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants